writeup, code: it's done! (mostly) also fix the bugs

- The writeup is done (modulo typos/final checking) now!
- We fixed a few bugs that caused the tests to fail. Yay!

ircd.lisp

@@ -203,6 +203,8 @@ Stolen from https://stackoverflow.com/questions/59043375/lisp-chunking-a-vector"
               (raise-user-error-with-text 'err-nosuchchannel "Channel does not exist"))
             (unless (groupchat-member-p gcid (client-userid c))
               (raise-user-error-with-text 'err-cannotsendtochan "You're not in that groupchat"))
+            (unless (check-groupchat-capability gcid (client-userid c) :send-message)
+              (raise-user-error-with-text 'err-cannotsendtochan "You can't speak in that groupchat"))
             (insert-db-message (client-userid c) tags (car (last params))
                                :gcid-to gcid
                                :is-notice is-notice))
@@ -313,6 +315,8 @@ If the operation is unrecognized (or too complex for this basic implementation),
             (check-groupchat-member gcid uid)
             (unless (groupchat-member-p gcid target)
               (raise-user-error 'err-usernotinchannel))
+            (unless (check-groupchat-capability gcid uid :change-roles)
+              (raise-user-error 'err-chanoprivsneeded (get-groupchat-name gcid)))
             (update-groupchat-membership gcid target new-role)
             (insert-db-mode-message uid gcid (second params) target)
             (notify-new-messages)))))))
@@ -338,7 +342,7 @@ If the operation is unrecognized (or too complex for this basic implementation),
           (notify-new-messages))))))
 
 (defmethod handle-irc-message ((c registered-irc-client) (msg msg-names))
-  (with-accessors ((params message-parameters)) msg
+  (with-accessors ((params message-parameters)) msroles
     (with-accessors ((uid client-userid)) c
       (let ((gcid (get-groupchat-target (first params))))
         (check-groupchat-member gcid uid)
@@ -411,28 +415,34 @@ When they arrive, it delivers them to connected clients."
     (pomo:with-transaction ()
       (for-each-client (uid devid client)
         (let* ((messages (pomo:query
-                         (:select 'm.* :distinct
-                          :from (:as 'messages 'm) (:as 'local_user_devices 'lud) (:as 'groupchat_memberships 'gcm)
-                          :where (:and
-                                  (:= 'lud.id '$2)
-                                  (:< 'lud.highest_seq 'm.seq)
-                                  (:or
-                                   (:= 'm.user_to '$1)
-                                   (:and
-                                    (:= 'gcm.user_id '$1)
-                                    (:= 'gcm.groupchat_uuid 'm.groupchat_to)))))
+                          (:order-by
+                           (:select 'm.* :distinct
+                                    :from (:as 'messages 'm) (:as 'local_user_devices 'lud)
+                                    :left-join (:as 'groupchat_memberships 'gcm) :on (:= 'gcm.user_id '$1)
+                                    :where (:and
+                                            (:= 'lud.id '$2)
+                                            (:< 'lud.highest_seq 'm.seq)
+                                            (:or
+                                             (:= 'm.user_to '$1)
+                                             (:and
+                                              (:= 'gcm.user_id '$1)
+                                              (:= 'gcm.groupchat_uuid 'm.groupchat_to)))))
+                           'seq)
                          uid devid (:dao db-message)))
                (system-messages (pomo:query
-                                 (:select 'm.* :distinct
-                                  :from (:as 'system_messages 'm) (:as 'local_user_devices 'lud) (:as 'groupchat_memberships 'gcm)
-                                  :where (:and
-                                          (:= 'lud.id '$2)
-                                          (:< 'lud.highest_seq 'm.seq)
-                                          (:or
-                                           (:= 'm.target_user_ref '$1)
-                                           (:and
-                                            (:= 'gcm.user_id '$1)
-                                            (:= 'gcm.groupchat_uuid 'm.groupchat_ref)))))
+                                 (:order-by
+                                  (:select 'm.* :distinct
+                                           :from (:as 'system_messages 'm) (:as 'local_user_devices 'lud)
+                                           :left-join (:as 'groupchat_memberships 'gcm) :on (:= 'gcm.user_id '$1)
+                                           :where (:and
+                                                   (:= 'lud.id '$2)
+                                                   (:< 'lud.highest_seq 'm.seq)
+                                                   (:or
+                                                    (:= 'm.target_user_ref '$1)
+                                                    (:and
+                                                     (:= 'gcm.user_id '$1)
+                                                     (:= 'gcm.groupchat_uuid 'm.groupchat_ref)))))
+                                  'seq)
                                 uid devid (:dao db-system-message)))
                (both-messages (nconc messages (mapcar #'parse-db-system-message system-messages)))
                (seq (loop

timestamps.lisp

@@ -37,3 +37,5 @@ For example, a message sent an hour ago might only show the time, whereas a mess
                      (return-from timestamp-to-human-time-prefix nil)
                      *human-time-format*)
                  *human-date-and-time-format*))))
+
+(setf local-time:*default-timezone* local-time:+utc-zone+)

writeup/6.2.1.txt

@@ -0,0 +1,21 @@
+[eeeeeta@superare nea-2019]$ ./nea-ircd -n nea-ircd -U eeeeeta -D nea2 --new-username test --new-password password
+Running NEA IRCd with server name 'nea-ircd'.
+Connecting to database using: (nea2 eeeeeta  localhost PORT 5432)
+Creating new user...done.
+[eeeeeta@superare nea-2019]$ ./nea-ircd -n nea-ircd -U eeeeeta -D nea2 --new-username test2 --new-password password
+Running NEA IRCd with server name 'nea-ircd'.
+Connecting to database using: (nea2 eeeeeta  localhost PORT 5432)
+Creating new user...done.
+[eeeeeta@superare nea-2019]$ psql -d nea2
+psql (12.1)
+Type "help" for help.
+
+nea2=# SELECT * FROM users;
+ id | username | server 
+----+----------+--------
+  1 | eta      |      1
+  2 | test     |      1
+  3 | test2    |      1
+(3 rows)
+
+nea2=# \q